From 1cb5ad3ac294ca8ff57754f1ee4078a516e84d5a Mon Sep 17 00:00:00 2001 From: Dan Fandrich Date: Wed, 29 Jan 2025 09:21:14 -0800 Subject: [PATCH] Expand note about xmlstarlet decompression According to https://gitlab.gnome.org/GNOME/libxml2/-/issues/848#note_2333727, transparent decompression will be removed from libxml2 which will affect xmlstarlet. --- autodescribe | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/autodescribe b/autodescribe index e68f023..9902b83 100755 --- a/autodescribe +++ b/autodescribe @@ -704,7 +704,9 @@ comment_svg () { # File type: svgz (Compressed Scalable Vector Graphics image) # requires: gzip, xmlstarlet -# TODO: xmlstarlet can transparently gzip-decompress, so replace with comment_svg +# TODO: xmlstarlet can optionally transparently decompress, but that feature is +# likely to be removed some time after 2025 so we shouldn't rely on it here (or +# for certain other file types). comment_svgz () { COMMENT=$(gzip -dc < "$1" | xmlstarlet sel -t -v "/*[local-name()='svg']/*[local-name()='title']" 2> /dev/null) if [ -z "$COMMENT" ] ; then