Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use on 1.10 #41

Closed
willtebbutt opened this issue Aug 21, 2023 · 3 comments
Closed

Use on 1.10 #41

willtebbutt opened this issue Aug 21, 2023 · 3 comments

Comments

@willtebbutt
Copy link
Collaborator

At present, CompilerPluginTools.jl does not precompile on 1.10.0-beta2. I do not know this will cease to be the case.

For Julia version 1.9 and up, this package doesn't technically require CompilerPluginTools.jl.

@dfdx do you have thoughts on what the best way forwards is for having this package work on 1.10? The options that I can see are

  1. fix CompilerPluginTools on 1.10 (I've not interacted with that package so don't know how to fix it, and I'm not whether it's actively maintained), or
  2. drop Julia versions below 1.8, and this package's dependency on CompilerPluginTools.

What are your thoughts? Maybe I've missed an option?

@dfdx
Copy link
Owner

dfdx commented Aug 21, 2023

#43 explores option (2). As you can see in CI/CD, the tests still fail because of changes in Core.Compiler.IRCode structure. We can fix it now, but since it's not a release yet, there's a high chance to get more breaking changes very soon. So unless you have an urgent use case, I'd say let's wait for the release and see what it takes to make Umlaut work on Julia 1.10.

@willtebbutt
Copy link
Collaborator Author

Sounds good to me

@willtebbutt
Copy link
Collaborator Author

Fixed by #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants