Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internalize dependency on "jupyter-jvm-basekernel" #33

Closed
andrus opened this issue Aug 16, 2024 · 1 comment
Closed

Internalize dependency on "jupyter-jvm-basekernel" #33

andrus opened this issue Aug 16, 2024 · 1 comment
Assignees
Milestone

Comments

@andrus
Copy link
Contributor

andrus commented Aug 16, 2024

JJava (same as its ancestor, iJava) depends on io.github.spencerpark:jupyter-jvm-basekernel that is no longer supported. Among other things, this causes dependency issues like #31.

We will need to internalize io.github.spencerpark:jupyter-jvm-basekernel, either as a separate subproject of DFLib, but more likely as a module in a multi-module jjava project. Then we can fully control the dependency stack, etc. E.g. we can start by upgrading gson dependency, and then switch to something else (or shade the dependency).

@andrus
Copy link
Contributor Author

andrus commented Aug 16, 2024

@stariy95 , interestingly, even though we override the GSON dependency to 2.8.9 in JJava, the user still sees 2.8.5 per #31 🤔

@stariy95 stariy95 added this to the 1.0-M3 milestone Aug 22, 2024
@stariy95 stariy95 self-assigned this Aug 26, 2024
@stariy95 stariy95 closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants