Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 #290

Closed
wants to merge 1 commit into from
Closed

PHP 8.4 #290

wants to merge 1 commit into from

Conversation

gnutix
Copy link
Contributor

@gnutix gnutix commented Jan 10, 2025

Got the same "infinite loop" error with composer-require-checker.

Comment on lines +21 to +30
"repositories": [
{
"type": "vcs",
"url": "https://github.com/tipee-sa/zendframework1-validate"
},
{
"type": "vcs",
"url": "https://github.com/tipee-sa/zendframework1-filter"
}
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be reverted.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (1dd5260) to head (f95796b).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #290      +/-   ##
============================================
- Coverage     97.40%   97.34%   -0.06%     
  Complexity      184      184              
============================================
  Files             1        1              
  Lines           424      415       -9     
============================================
- Hits            413      404       -9     
  Misses           11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaydiablo
Copy link
Member

Added in #291, thanks!

@jaydiablo jaydiablo closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants