fix: save in-progress data for interrupted reads #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing logic for `poll_read_all()` recreates the read buffer on reentry. When the read underneath returns `Pending`, the data that has already been read gets discarded. This commit accumulates the data from every read inside of `Entries`.
This was referenced Dec 24, 2024
charliermarsh
added a commit
to astral-sh/tokio-tar
that referenced
this pull request
Feb 9, 2025
## Summary Right now, if we hit a pending read while reading an entry, we end up discarding the data rather than preserving it for the next poll (e.g., for a PAX extension). You can also see this reported at dignifiedquire/async-tar#39. This PR takes dignifiedquire/async-tar#55, but applies an additional change as that PR didn't work on its own, in my testing. Atop dignifiedquire/async-tar#55, we also store the pending `Entry` to ensure that if we're pending, we don't advance to the next entry on the next poll. For more context, see: #1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing logic for
poll_read_all()recreates the read buffer on reentry. When the read underneath returnsPending, the data that has already been read gets discarded.This commit accumulates the data from every read inside of
Entries.Closes #39