Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Eta? #342

Open
carolinaisslaying opened this issue Mar 1, 2025 · 3 comments
Open

Switch to Eta? #342

carolinaisslaying opened this issue Mar 1, 2025 · 3 comments
Labels
help wanted Applied when a feature request/bug needs help to be implemented/fixed.

Comments

@carolinaisslaying
Copy link
Member

Currently, DEL uses EJS, and it's switching to React, Vue, or any other similar alternative would require a significant rewrite of the entire codebase.

However, I've come across an alternative to EJS called Eta, which is quite similar but supports a few more features (from my understanding this includes typescript types) and it is also significantly faster in its benchmarks.

Switching to Eta from my understanding wouldn't be very significant, it could be as easy as:

  1. remove ejs import and switching to eta, ctrl replace <%- to <%~ (I believe)
    OR
  2. coincide with improvements to all of the templates to be less all over the place (cleaning up inline styles and code, using eta layouts, cleaning up the entire views directory)

Thought I'd get thoughts on what to do with this?

@carolinaisslaying carolinaisslaying added the help wanted Applied when a feature request/bug needs help to be implemented/fixed. label Mar 1, 2025
@Connor200024
Copy link

Would you ever personally look at React? I have worked/used it for over a year now and I must admit its a lot better performance wise. :)

But if you don't wish to re code the website as a whole. I would do the improvements. I have checked over the code and yeah its a mess. :D

@carolinaisslaying
Copy link
Member Author

I think the level of change required with React is just too much for it to realistically be an option without near starting from scratch.

Either way implementing even this (option 2) would require a lot of effort but is definitely more feasible. I'd say that firstly the actual backend code would need to be improved quite a lot in terms of removing all the duplication.

@Connor200024
Copy link

Yeah true, Makes more sense. Option 2 might be better. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Applied when a feature request/bug needs help to be implemented/fixed.
Projects
None yet
Development

No branches or pull requests

2 participants