Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests in CspRenderingTestCase #2082

Open
dr-rompecabezas opened this issue Feb 18, 2025 · 2 comments · May be fixed by #2088
Open

Fix failing tests in CspRenderingTestCase #2082

dr-rompecabezas opened this issue Feb 18, 2025 · 2 comments · May be fixed by #2088

Comments

@dr-rompecabezas
Copy link
Member

dr-rompecabezas commented Feb 18, 2025 •
edited
Loading

Related to a django-csp package incompatibility, as reported in a comment for PR #2081.

Edit: see also seemingly related conversation in issue #2058.
@tim-schilling tim-schilling mentioned this issue Feb 21, 2025
Open
matthiask added a commit to matthiask/django-debug-toolbar that referenced this issue Feb 25, 2025
@matthiask
Pinned django-csp's version used for our tests
cb78335 
The issue has been reported upstream, for now we just want passing tests.

Refs django-commons#2082.
@matthiask matthiask mentioned this issue Feb 25, 2025
Merged
matthiask added a commit that referenced this issue Feb 25, 2025
@matthiask
Pinned django-csp's version used for our tests (#2084)
e5378e0 
The issue has been reported upstream, for now we just want passing tests.

Refs #2082.
@matthiask matthiask mentioned this issue Feb 25, 2025
Merged
2 tasks
@tim-schilling tim-schilling linked a pull request Feb 26, 2025 that will close this issue
Open
2 tasks
dr-rompecabezas pushed a commit to dr-rompecabezas/django-debug-toolbar that referenced this issue Mar 5, 2025
@matthiask @dr-rompecabezas
Pinned django-csp's version used for our tests (django-commons#2084)
004a581 
The issue has been reported upstream, for now we just want passing tests.

Refs django-commons#2082.
@jwhitlock
Copy link

django-csp 4.0b5 is released, hopefully fixing this issue.

@jwhitlock
Copy link

I'm running the tests locally with django-csp 4.0b5, they are still failing. Looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rely on django-csp's private attribute for nonce django-commons/django-debug-toolbar
2 participants
@jwhitlock @dr-rompecabezas