notify nvim on unexpected errors

Author: dlants

bun/index.ts

@@ -1,5 +1,6 @@
 import { attach, type LogLevel } from "bunvim";
 import { Magenta } from "./magenta.ts";
+import { notifyErr } from "./nvim/nvim.ts";
 
 // These values are set by neovim when starting the bun process
 const ENV = {
@@ -16,6 +17,8 @@ const nvim = await attach({
 });
 
 process.on("uncaughtException", (error) => {
+  // eslint-disable-next-line @typescript-eslint/no-floating-promises
+  notifyErr(nvim, error);
   nvim.logger?.error(error);
   process.exit(1);
 });

bun/magenta.ts

@@ -6,7 +6,7 @@ import { pos } from "./tea/view.ts";
 import type { Nvim } from "bunvim";
 import { Lsp } from "./lsp.ts";
 import { PROVIDER_NAMES, type ProviderName } from "./providers/provider.ts";
-import { getCurrentBuffer, getcwd, getpos } from "./nvim/nvim.ts";
+import { getCurrentBuffer, getcwd, getpos, notifyErr } from "./nvim/nvim.ts";
 import path from "node:path";
 import type { Line } from "./nvim/buffer.ts";
 import { pos1to0, type ByteIdx } from "./nvim/window.ts";
@@ -63,6 +63,8 @@ export class Magenta {
           await this.sidebar.updateProvider(provider as ProviderName);
         } else {
           this.nvim.logger?.error(`Provider ${provider} is not supported.`);
+          // eslint-disable-next-line @typescript-eslint/no-floating-promises
+          notifyErr(this.nvim, `Provider ${provider} is not supported.`);
         }
         break;
       }
@@ -187,6 +189,8 @@ ${lines.join("\n")}
 
       default:
         this.nvim.logger?.error(`Unrecognized command ${command}\n`);
+        // eslint-disable-next-line @typescript-eslint/no-floating-promises
+        notifyErr(this.nvim, `Unrecognized command ${command}\n`);
     }
   }
 
@@ -197,6 +201,8 @@ ${lines.join("\n")}
         this.mountedChatApp.onKey(key as BindingKey);
       } else {
         this.nvim.logger?.error(`Unexpected MagentaKey ${JSON.stringify(key)}`);
+        // eslint-disable-next-line @typescript-eslint/no-floating-promises
+        notifyErr(this.nvim, `Unexpected MagentaKey ${JSON.stringify(key)}`);
       }
     }
   }
@@ -224,6 +230,8 @@ ${lines.join("\n")}
             ? `Error executing command ${args[0] as string}: ${err.message}\n${err.stack}`
             : JSON.stringify(err),
         );
+        // eslint-disable-next-line @typescript-eslint/no-floating-promises
+        notifyErr(nvim, err);
       }
     });
 
@@ -247,7 +255,6 @@ ${lines.join("\n")}
       try {
         lsp.onLspResponse(args);
       } catch (err) {
-        console.error(err);
         nvim.logger?.error(JSON.stringify(err));
       }
     });

bun/nvim/nvim.ts

@@ -73,3 +73,11 @@ export async function getpos(
 export function diffthis(nvim: Nvim) {
   return nvim.call("nvim_command", ["diffthis"]);
 }
+
+export function notifyErr(nvim: Nvim, err: unknown) {
+  return nvim.call("nvim_notify", [
+    `Thunk execution error: ${err instanceof Error ? err.message : JSON.stringify(err)}`,
+    3,
+    {},
+  ]);
+}

bun/tea/tea.ts

@@ -7,7 +7,7 @@ import {
   type VDOMNode,
 } from "./view.ts";
 import { BINDING_KEYS, type BindingKey, getBindings } from "./bindings.ts";
-import { getCurrentWindow } from "../nvim/nvim.ts";
+import { getCurrentWindow, notifyErr } from "../nvim/nvim.ts";
 import type { Row0Indexed } from "../nvim/window.ts";
 import type { Nvim } from "bunvim";
 
@@ -102,6 +102,9 @@ export function createApp<Model, Msg>({
                 ? `Error: ${err.message}\n${err.stack}`
                 : JSON.stringify(err);
             nvim.logger?.error(`Thunk execution error: ${message}`);
+
+            // eslint-disable-next-line @typescript-eslint/no-floating-promises
+            notifyErr(nvim, err);
           });
         }
       }
@@ -128,6 +131,8 @@ export function createApp<Model, Msg>({
           .render({ currentState, dispatch })
           .catch((err) => {
             nvim.logger?.error(err as Error);
+            // eslint-disable-next-line @typescript-eslint/no-floating-promises
+            notifyErr(nvim, err);
             throw err;
           })
           .finally(() => {

bun/tools/listDirectory.ts

@@ -56,7 +56,6 @@ export const update: Update<Msg, Model> = (msg, model) => {
 async function listDirectoryBFS(
   startPath: string,
   cwd: string,
-  context: { nvim: Nvim },
 ): Promise<string[]> {
   const ig = await readGitignore(cwd);
   const queue: string[] = [startPath];
@@ -66,35 +65,31 @@ async function listDirectoryBFS(
   while (queue.length > 0 && results.length < 100) {
     const currentPath = queue.shift()!;
 
-    try {
-      const entries = await fs.promises.readdir(currentPath, {
-        withFileTypes: true,
-      });
+    const entries = await fs.promises.readdir(currentPath, {
+      withFileTypes: true,
+    });
 
-      for (const entry of entries) {
-        const fullPath = path.join(currentPath, entry.name);
-        const relativePath = path.relative(cwd, fullPath);
+    for (const entry of entries) {
+      const fullPath = path.join(currentPath, entry.name);
+      const relativePath = path.relative(cwd, fullPath);
 
-        // Skip hidden files and respected gitignored files
-        if (entry.name.startsWith(".") || ig.ignores(relativePath)) {
-          continue;
-        }
+      // Skip hidden files and respected gitignored files
+      if (entry.name.startsWith(".") || ig.ignores(relativePath)) {
+        continue;
+      }
 
-        if (!fullPath.startsWith(cwd)) {
-          continue;
-        }
+      if (!fullPath.startsWith(cwd)) {
+        continue;
+      }
 
-        if (!seen.has(fullPath)) {
-          seen.add(fullPath);
-          results.push(relativePath);
+      if (!seen.has(fullPath)) {
+        seen.add(fullPath);
+        results.push(relativePath);
 
-          if (entry.isDirectory()) {
-            queue.push(fullPath);
-          }
+        if (entry.isDirectory()) {
+          queue.push(fullPath);
         }
       }
-    } catch (error) {
-      context.nvim.logger?.error(error as Error);
     }
   }
 
@@ -133,7 +128,7 @@ export function initModel(
           return;
         }
 
-        const files = await listDirectoryBFS(absolutePath, cwd, context);
+        const files = await listDirectoryBFS(absolutePath, cwd);
         context.nvim.logger?.debug(`files: ${files.join("\n")}`);
         dispatch({
           type: "finish",

bun/tools/toolManager.ts

@@ -231,7 +231,9 @@ ${result.result.value}
   ) {
     return withBindings(
       d`${renderToolContents(model.model, dispatch)}${
-        model.showRequest ? d`\nid: ${model.model.request.id}\n${displayRequestInput(model.model)}` : ""
+        model.showRequest
+          ? d`\nid: ${model.model.request.id}\n${displayRequestInput(model.model)}`
+          : ""
       }${model.showResult ? displayResult(model.model) : ""}`,
       {
         "<CR>": () =>