Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blameable] Int is not a valid Doctrine type mapping #2006

Open
tezvi opened this issue Apr 4, 2019 · 4 comments
Open

[Blameable] Int is not a valid Doctrine type mapping #2006

tezvi opened this issue Apr 4, 2019 · 4 comments
Labels
Blameable Bug A confirmed bug in Extensions that needs fixing. Still Relevant Mark PRs that might've been auto-closed that are still relevant.

Comments

@tezvi
Copy link

tezvi commented Apr 4, 2019

https://github.com/Atlantic18/DoctrineExtensions/blob/ee6e427c759da76b65597870e2bae36fc7b09631/lib/Gedmo/Blameable/Mapping/Driver/Annotation.php#L29-L33

Is int value a valid Doctrine mapping type? It seems that "integer" should be used instead.
I've managed to defined custom doctrine type in symfony configuration so this works for me at framework level:

doctrine:
    dbal:
        types:
            int: Doctrine\DBAL\Types\IntegerType

However, it would be nice to have "integer" value in $validTypes collection as well, so everyone can be happy :)

Something similar is reported here but closed without proper resolution #1137

@tezvi tezvi changed the title [Blameable] Integer is not a valid Doctrine type mapping [Blameable] Int is not a valid Doctrine type mapping Apr 4, 2019
@AkenRoberts
Copy link
Member

It looks like @Padam87 addressed this in PR #1533, but it targeted a previous attempt at a 3.0 release which went abandoned.

I'll see if it can be cherry picked into 2.4.x. Thank you for the issue.

@theoboldt
Copy link

This seems to be quite strange - I suddenly updated today from
1f4899c5d3de8b9cdc5189a46ea9b94665be5f09 to f3bdc16fc2e793c37c1fefb1e4fa2f8a0a59edfc via 1f4899c...f3bdc16.

At the time of 1f4899c, integer was included in Annotation::$validTypes, now it itsn't. But I cannot determine when or in which commit this was removed.

theoboldt added a commit to theoboldt/DoctrineExtensions that referenced this issue May 3, 2019
@Marcelixoo
Copy link

Marcelixoo commented Aug 30, 2020

Will this be merged? I still have the same problem mentioned by @theoboldt :(

@phansys phansys added Blameable Bug A confirmed bug in Extensions that needs fixing. labels Nov 5, 2021
@github-actions
Copy link

github-actions bot commented May 5, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label May 5, 2022
@franmomu franmomu added Still Relevant Mark PRs that might've been auto-closed that are still relevant. and removed Stale labels May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blameable Bug A confirmed bug in Extensions that needs fixing. Still Relevant Mark PRs that might've been auto-closed that are still relevant.
Projects
None yet
Development

No branches or pull requests

6 participants