[no-release-notes] Change some tests to use t.TempDir instead of os.TempDir so that their temporary files get cleaned up. #8792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…empDir so that their temporary files get cleaned up.
…dows test cleanup works.
…ly removed on a replica
Co-authored-by: jycor <jcor@ucsd.edu>
…equests so that a GC does not end while they are in progress.
…pendencies on chunks during reads.
…chunks which were in the memtable but get filtered out because they are already in the store.
…h for chunks that are written but which are already present in the store.
…g, make it so that reading chunks as part of the GC process does not take further dependencies on them and never blocks on waitForGC.
…callbacks to the replica controller execution context session.
This makes small clean ups to the lifecycle around replica applier and the
ownership and lifecycle of the mysql.Conn read connection.
This PR also includes some changes to slightly improve the performance and
reliability of the tests when running them locally. In particular, some of the
changes include:
1) Since `go run ./cmd/dolt` takes about four seconds to validate the existing
cached build on my laptop, we just go ahead and use a cached build everywhere.
2) We use t.Log{f,} instead of fmt.Prin.. to improve the ergonomics of test
running and getting output from a failure in particular.
3) We try to minimize global process state changes like unnecessary `os.Chdir`
calls, since it would be nice to parallelize these tests eventually.
4) We get rid of the unused and seemingly unnecessary --socket= argument to
Dolt, where we had to use a directory not corresponding to $TMPDIR, for
example, because max pathlength on a sun_path on MacOS is 104 characters or
whatever.
…ose when closing the SqlEngine.
…dependencies on chunks read from OldGen.
…, sort in lexicographical order
…s for better deprecation process
…System, remove the confusing indirection through ctxFactory.
….Contexts used in remotesrv RPCs.
This PR changes each RPC invocation against the gRPC and HTTP servers
implementing remotesapi and cluster replication to create a sql.Context
which lives the duration of the call. The Session for that call gets
SessionCommand{Begin,End} and SessionEnd lifecycle callbacks so that it
can participate in GC safepoint rendezvous appropriately.
Previously the remotesrv.DBCache and the user/password remotesapi
authentication implementation would simply create new sql.Contexts
whenever they needed them. There could be multiple sql.Contexts for the
single server call.
Co-authored-by: Maximilian Hoffman <max@dolthub.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.