Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field marked as deprecated causes pipeline failure even though value used is None #61

Closed
OnlyFerris opened this issue Jan 4, 2024 · 1 comment
Closed

Field marked as deprecated causes pipeline failure even though value used is None #61

OnlyFerris opened this issue Jan 4, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@OnlyFerris
Copy link
Contributor

OnlyFerris commented Jan 4, 2024 •
edited
Loading

Describe the bug

error: use of deprecated field `v1::chat_completion::ChatCompletionRequest::function_call`: This field is deprecated. Use `tool_choice` instead.
  --> src/v1/chat_completion.rs:77:13
   |
77 |             function_call: None,
   |             ^^^^^^^^^^^^^^^^^^^

It seems that marking the field as deprecated is not working as intended. Even though "None" is specified, it triggers a complaint, which makes pipeline fail. In the code where the ChatCompletionRequest constructs itself using its new(...) method.

This change was introduced in #54

To Reproduce

See pipeline in main branch

Code snippets

No response

OS

All

Rust version

Any

Library version

openai-api-rs v2.1.7
@OnlyFerris OnlyFerris added the bug Something isn't working label Jan 4, 2024
@OnlyFerris OnlyFerris mentioned this issue Jan 4, 2024
Closed
@dongri
Copy link
Owner

dongri commented Jan 6, 2024

@OnlyFerris Thank you!
I remove Deprecated function
#63

@dongri dongri closed this as completed Jan 6, 2024
ra0x3 pushed a commit to ra0x3/openai-rst that referenced this issue May 3, 2024
@ariaxxxi
fix ux problems (dongri#61)
74ed913 
* fix ux problems

- popup card style made translucent
- question mark navigate to faq in swiper
- add logo everywhere
- update quiz result style

* kill warnings + yarn pretty

* update popup position

* update position of popup card

* delete commented code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dongri @OnlyFerris