Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI should check the dev container setup #18321

Open
Martin521 opened this issue Feb 17, 2025 · 4 comments
Open

CI should check the dev container setup #18321

Martin521 opened this issue Feb 17, 2025 · 4 comments
Labels
Area-Tooling Generic tooling bugs and suggestions, which do not fall into any existing category. Continuous Improvement help wanted
Milestone
Backlog

Comments

@Martin521
Copy link
Contributor

There should be a check in CI that building in a dev container succeeds.
So that authors changing global.json are reminded of the necessary changes to .devcontainer/devcontainer.json.
@github-actions github-actions bot added this to the Backlog milestone Feb 17, 2025
@TheAngryByrd
Copy link
Contributor

Example: https://github.com/TheAngryByrd/MiniScaffold/blob/cbef1f34ac9db74321e22c0d52eb9bf9c886515b/.github/workflows/build.yml#L44-L55

@vzarytovskii
Copy link
Member

Example: https://github.com/TheAngryByrd/MiniScaffold/blob/cbef1f34ac9db74321e22c0d52eb9bf9c886515b/.github/workflows/build.yml#L44-L55

That particular approach won't work. All CI which builds code should run in azdo.

@Martin521
Copy link
Contributor Author

Currently devcontainer build is broken, the SDK requested by global.json is not installed.
I figure there is no easy fix because a devcontainer image is available only for the latest version (9.0.200), and global.json currently still needs to be on 9.0.103, is that correct?

@vzarytovskii
Copy link
Member

Currently devcontainer build is broken, the SDK requested by global.json is not installed.
I figure there is no easy fix because a devcontainer image is available only for the latest version (9.0.200), and global.json currently still needs to be on 9.0.103, is that correct?

Devcontainer should be updated together with global.json. If it wasn't, it was a mistake. They simply need to be in sync.

@abonie abonie added help wanted Area-Tooling Generic tooling bugs and suggestions, which do not fall into any existing category. Continuous Improvement and removed Needs-Triage labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Tooling Generic tooling bugs and suggestions, which do not fall into any existing category. Continuous Improvement help wanted
Projects
F# Compiler and Tooling
Status: New
Milestone
Backlog
Development

No branches or pull requests
4 participants
@vzarytovskii @TheAngryByrd @abonie @Martin521