Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDN test failure on .NET 8.0 #110499

Closed
tarekgh opened this issue Dec 7, 2024 · 6 comments
Closed

IDN test failure on .NET 8.0 #110499

tarekgh opened this issue Dec 7, 2024 · 6 comments
Assignees
Labels
area-System.Globalization blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab
Milestone

Comments

@tarekgh
Copy link
Member

tarekgh commented Dec 7, 2024

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=888621
Build error leg or test failing: System.Globalization.Tests.IdnMappingIdnaConformanceTests.GetAscii_Invalid
Pull request: #110492

Error Message

Expected IdnMapping.GetAscii("xn----ufo9661d.xn--r5gy929fhm4f") to throw an ArgumentException. Line Number: 6126

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "to throw an ArgumentException. Line Number: 6126",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

We made fixes last year that need to be backported to release/8.0. These probably should have been backported at the time of the earlier PR. Not a criticism but just an observation. This type of change typically affects all the distros in a staggered fashion and affects our LTS versions.

Related:

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=888621
Error message validated: [Expected IdnMapping.GetAscii to throw an ArgumentException. Line Number: 6126]
Result validation: ❌ Known issue did not match with the provided build.
Validation performed at: 12/7/2024 3:35:12 AM UTC

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=888621
Error message validated: [to throw an ArgumentException. Line Number: 6126]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 12/7/2024 3:36:45 AM UTC

Report

Build Definition Test Pull Request
894944 dotnet/runtime System.Globalization.Tests.IdnMappingIdnaConformanceTests.GetUnicode_Invalid #110651
893697 dotnet/runtime System.Globalization.Tests.IdnMappingIdnaConformanceTests.GetAscii_Invalid #110651
894059 dotnet/runtime System.Globalization.Tests.IdnMappingIdnaConformanceTests.GetUnicode_Invalid #109648
893209 dotnet/runtime System.Globalization.Tests.IdnMappingIdnaConformanceTests.GetUnicode_Invalid
893212 dotnet/runtime System.Globalization.Tests.IdnMappingIdnaConformanceTests.GetUnicode_Invalid
888621 dotnet/runtime System.Globalization.Tests.IdnMappingIdnaConformanceTests.GetUnicode_Invalid #110492

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
2 5 6
@tarekgh tarekgh added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Dec 7, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Dec 7, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@tarekgh tarekgh added area-System.Globalization and removed area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels Dec 7, 2024
@tarekgh tarekgh added this to the 8.0.x milestone Dec 7, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Dec 13, 2024

@tarekgh It is not ok to use "Known Build Errors" to ignore deterministic failures introduced by the PR. Our goal is to have green CI.

You should disable the failing test against an issue in situations like this instead.

@tarekgh
Copy link
Member Author

tarekgh commented Dec 13, 2024

@jkotas there is no change in the PR caused the failure. It is because the environment is now using an updated version of ICU which is causing the failure. So, there is no real product problem. We have fixed the test in main but back port the fix failed. I am currently off, if I get a chance soon to log in will try to either port the fix manually or disable the test.

@tarekgh
Copy link
Member Author

tarekgh commented Dec 13, 2024

@jkotas I have created the PR #110705.

CC @ericstj @carlossanlop if can help merging it when the CI finish.

@jkotas
Copy link
Member

jkotas commented Dec 14, 2024

Thank you!

@jkotas jkotas closed this as completed Dec 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Globalization blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab
Projects
None yet
Development

No branches or pull requests

2 participants