-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDN test failure on .NET 8.0 #110499
Comments
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
Tagging subscribers to this area: @dotnet/area-system-globalization |
@tarekgh It is not ok to use "Known Build Errors" to ignore deterministic failures introduced by the PR. Our goal is to have green CI. You should disable the failing test against an issue in situations like this instead. |
@jkotas there is no change in the PR caused the failure. It is because the environment is now using an updated version of ICU which is causing the failure. So, there is no real product problem. We have fixed the test in main but back port the fix failed. I am currently off, if I get a chance soon to log in will try to either port the fix manually or disable the test. |
@jkotas I have created the PR #110705. CC @ericstj @carlossanlop if can help merging it when the CI finish. |
Thank you! |
Build Information
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=888621
Build error leg or test failing: System.Globalization.Tests.IdnMappingIdnaConformanceTests.GetAscii_Invalid
Pull request: #110492
Error Message
Expected IdnMapping.GetAscii("xn----ufo9661d.xn--r5gy929fhm4f") to throw an ArgumentException. Line Number: 6126
Fill the error message using step by step known issues guidance.
We made fixes last year that need to be backported to release/8.0. These probably should have been backported at the time of the earlier PR. Not a criticism but just an observation. This type of change typically affects all the distros in a staggered fashion and affects our LTS versions.
Related:
Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=888621
Error message validated:
[Expected IdnMapping.GetAscii to throw an ArgumentException. Line Number: 6126
]Result validation: ❌ Known issue did not match with the provided build.
Validation performed at: 12/7/2024 3:35:12 AM UTC
Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=888621
Error message validated:
[to throw an ArgumentException. Line Number: 6126
]Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 12/7/2024 3:36:45 AM UTC
Report
Summary
The text was updated successfully, but these errors were encountered: