Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook the Rust-based library to the existing benchmarks #5

Closed
rlouf opened this issue Aug 16, 2024 · 1 comment · Fixed by #7
Closed

Hook the Rust-based library to the existing benchmarks #5

rlouf opened this issue Aug 16, 2024 · 1 comment · Fixed by #7
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@rlouf
Copy link
Member

rlouf commented Aug 16, 2024

The only way we can make sure we are going in the right direction is to run the benchmarks that were implemented to monitor regressions in Outlines in CI. We should compare both the Rust and pure Python implementation for each Pull Request.
@rlouf rlouf added enhancement New feature or request help wanted Extra attention is needed labels Aug 16, 2024
@rlouf rlouf linked a pull request Aug 21, 2024 that will close this issue
Replace basic Numba FSM functions with Rust implementations #7
Merged
3 tasks
@rlouf
Copy link
Member Author

rlouf commented Aug 21, 2024

Close as completed by #7

@rlouf rlouf closed this as completed Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace basic Numba FSM functions with Rust implementations dottxt-ai/outlines-core
1 participant
@rlouf