Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of sds arguments in SortedMap #4639

Open
romange opened this issue Feb 20, 2025 · 0 comments · May be fixed by #4738
Open

get rid of sds arguments in SortedMap #4639

romange opened this issue Feb 20, 2025 · 0 comments · May be fixed by #4738
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@romange
Copy link
Collaborator

romange commented Feb 20, 2025

(good for starter tasks)

SortedMap still has some methods with sds because zset_family code uses sds and that in turn due to reliance on zzl utlilites like zzlFind

  1. We should reimplement zzl utilities using string_view instead of sds, (only those that we need of course),
    and use where they are needed in zset_family, similarly to how we implemented LpFind vs lpFind
  2. We should get rid of SdsWrap calls in zset_family and pass string_view directly.
  3. We should get rid of functions accepting sds arguments inside SortedMap.

An example PR that does such cleanup: #4638

@romange romange added the enhancement New feature or request label Feb 20, 2025
@adiholden adiholden added the good first issue Good for newcomers label Feb 26, 2025
@adiholden adiholden assigned abhijat and unassigned adiholden Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants