You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
SortedMap still has some methods with sds because zset_family code uses sds and that in turn due to reliance on zzl utlilites like zzlFind
We should reimplement zzl utilities using string_view instead of sds, (only those that we need of course),
and use where they are needed in zset_family, similarly to how we implemented LpFind vs lpFind
We should get rid of SdsWrap calls in zset_family and pass string_view directly.
We should get rid of functions accepting sds arguments inside SortedMap.
(good for starter tasks)
SortedMap still has some methods with sds because zset_family code uses sds and that in turn due to reliance on zzl utlilites like
zzlFind
and use where they are needed in zset_family, similarly to how we implemented
LpFind
vslpFind
SdsWrap
calls in zset_family and pass string_view directly.An example PR that does such cleanup: #4638
The text was updated successfully, but these errors were encountered: