Make documentation generation optional and improve objc path specification #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## swifty-dropbox-beta #320 +/- ##
=======================================================
- Coverage 50.30% 49.93% -0.38%
=======================================================
Files 37 37
Lines 8740 8805 +65
Branches 1881 1889 +8
=======================================================
Hits 4397 4397
- Misses 4026 4091 +65
Partials 317 317
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aaronsky
approved these changes
Feb 8, 2024
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| import Foundation | |||
|
|
|||
| enum {{ class_name }} { | |||
| enum {{ class_name }}: ReconnectionHelpersShared { | |||
There was a problem hiding this comment.
It's a needed but unrelated change
|
|
||
| def _generate_jazzy_docs(self, api): | ||
| jazzy_cfg_path = os.path.join('../Format', 'jazzy.json') |
There was a problem hiding this comment.
nit – sad this relpath still couldn't be fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow generate_base_client.py to be run from directories other than where it is located, the root of SwiftyDropbox.
Paired with: dropbox/SwiftyDropbox#401
-ropflag is removed--objcoption updated updated to not suggest that a single pass generation is possible._write_output_in_target_foldersimplified to just write toself.target_folder_path+file name. For objc generation specify the output location using-o.Checklist
General Contributing
Is This a Code Change?
Validation
tox?