fix: do not overwrite existing values with route param values

Author: dshafik

src/Bag/Pipelines/Pipes/LaravelRouteParameters.php

@@ -28,6 +28,10 @@ public function __invoke(BagInput $input): BagInput
         Reflection::getParameters(Reflection::getConstructor($input->bagClassname))->each(function ($parameter) use ($input) {
             /** @var ReflectionParameter $parameter */
 
+            if (isset($input->values[$parameter->getName()]) && $input->values[$parameter->getName()] !== null) {
+                return;
+            }
+
             /** @var FromRouteParameter|FromRouteParameterProperty|null $attribute */
             $attribute = Reflection::getAttributeInstance($parameter, FromRouteParameter::class) ?? Reflection::getAttributeInstance($parameter, FromRouteParameterProperty::class);
             if ($attribute === null) {

tests/Unit/Pipelines/Pipes/LaravelRouteParametersTest.php

@@ -27,6 +27,16 @@
         ->and($input->values->get('notNamedStringParam'))->toBe('testing');
 });
 
+
+test('it does not overwrite existing data', function () {
+    $this->get('/string/testing');
+
+    $input = runPipeline(['stringParam' => 'existing', 'notNamedStringParam' => 'existing']);
+
+    expect($input->values->get('stringParam'))->toBe('existing')
+        ->and($input->values->get('notNamedStringParam'))->toBe('existing');
+});
+
 test('it populates int parameter value', function () {
     $this->get('/int/1234');
 
@@ -133,9 +143,9 @@
         ->and($input->values->get('notNamedStringParam'))->toBe('overridden');
 });
 
-function runPipeline(): BagInput
+function runPipeline($data = []): BagInput
 {
-    $input = new BagInput(BagWithRequestParams::class, collect());
+    $input = new BagInput(BagWithRequestParams::class, collect($data));
 
     $input = (new ProcessParameters())($input);
     $input = (new MapInput())($input);