Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UMD version #28

Closed
vanodevium opened this issue Jul 12, 2024 · 4 comments
Closed

UMD version #28

vanodevium opened this issue Jul 12, 2024 · 4 comments

Comments

@vanodevium
Copy link
Collaborator

image

Maybe we can add some configuration to avoid this style errors?

@dy
Copy link
Owner

dy commented Jul 12, 2024

Do you mean just code formatting? It's done via esbuild-plugin-umd-wrapper, the only way to do that is posting an issue there.
Do you expect UMD entry to be readable? I'd anticipate it to be used more as obfuscated sprae.umd.min.js with help of sourcemaps.

@vanodevium
Copy link
Collaborator Author

vanodevium commented Jul 12, 2024

@dy

Yeap, only red lines in the editor.

It's parseable by browser, so there is some aesthetic question :)

@dy
Copy link
Owner

dy commented Jul 12, 2024

If you want to post an issue there please do.
But l&f of bundled entries is not priority at all here, so I'll close it if you don't mind.

@dy dy closed this as completed Jul 12, 2024
@vanodevium
Copy link
Collaborator Author

@dy it's OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants