Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just question: directives priority #32

Closed
vanodevium opened this issue Jul 12, 2024 · 3 comments
Closed

Just question: directives priority #32

vanodevium opened this issue Jul 12, 2024 · 3 comments

Comments

@vanodevium
Copy link
Collaborator

If there is a "slight" problem with the priority of directives (for example, each and text), then perhaps it is necessary not only to read all the attributes in a row, but also to add the priority of reading.

@dy
Copy link
Owner

dy commented Jul 13, 2024

Depends on your case.

Generally priority is defined by order of directives on a tag, so you should be considerate about it. That's in the readme#hints section.

That's the nature of sprae engine, there used to be primary/secondary directive groups, which proved to be foolproof but unnecessary.

So if you show convincing use-case I can reconsider, but so far some mental exercise of properly ordering directives seems to be healthy.

@vanodevium
Copy link
Collaborator Author

@dy

Sounds convincing.

Unless, in my opinion, it should be raised from the hints exactly to each directive, so that it immediately catches the eye and it is clear that if it does not work - most likely, the user specified it in the wrong order.

@dy
Copy link
Owner

dy commented Jul 13, 2024

I added a little note in :each description.

@dy dy closed this as completed Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants