TARDIS addon integration

[DalekCraft2]

I am wondering about whether I may integrate TARDIS-Dynmap and TARDISChunkGenerator into the base plugin. The first is very simple, and the second is necessary for the base plugin to function.

[Chew]

If you're dependant on them you can put it in your plugin.yml, not sure why you would need to just copy the code since they are plugins.
Anyway, the answer is technically/legally yes because of GPL and all that. Should give credit though.

[DalekCraft2]

Well, I am doing this for a pull request.

[Chew]

Oh I misread, I'm sure they're separate for a reason, what that reason is we'll find out 😂

[eccentricdevotion]

Not possible I believe.
You need to consider load order and dependencies.
TARDISChunkGenerator is a world generator so has load: STARTUP in plugin.yml so loads before any worlds are loaded.
Dynmap-TARDIS has load: POSTWORLD in plugin.yml, and also a dependency on both the Dynmap plugin itself and the TARDIS plugin so needs to load after both plugins, and after worlds have loaded.

[eccentricdevotion]

You could however, combine Dynmap-TARDIS and the TARDIS plugin.

[DalekCraft2]

Would it be possible to move the non-chunk-generation files, such as disguises, to the main plugin? I want to integrate as much as possible.

[eccentricdevotion]

The reason for most of the code in TCG being there is because it uses Minecraft and CraftBukkt internals. It's easier to keep that code separate so that it is quicker to update and troubleshoot when new Minecraft versions are released.

[eccentricdevotion]

I really don't see any benefit in combining plugins...

[DalekCraft2]

I do not see the benefit in keeping them separate if they require each other to function.