From 8c655ab44f286c5acbba2c07218efdc8accf1023 Mon Sep 17 00:00:00 2001 From: Mahmoud Elkarargy <113839437+mahmoudElkarargyBS@users.noreply.github.com> Date: Tue, 25 Feb 2025 11:27:35 +0200 Subject: [PATCH] Ft add accuracy tlr (#26) * V1.1.1 (#15) * add the pow_exp kernel and tested * all fixes * resolve threads plus some modifications * Fix cuda * fix for linking cuda * fix: hicma modifactions * try fixing Jenkines * Adding R structure * fix:add doxygen in Jenkines * add test file for pow-exp kernel * test with -fpic * some modifications for HiCMA * updates * try 2 gpu devices * back to starsh * a potential fix to doxygen * roll back * test Rcpp * Fix Jenkines * fix errors * Updated in design * updates * all release issue without src checks * adding MakeFile * Updated MPI * Documentation * fix examples tests * modeling takes pointers * example for read and write data * fix: typpo in Initialize * fix passing numbers of theta * fix: performance of gsl * fix: GPU support * fix:mspe * updated devel * R branch init * tests:add r tests * fix tests * bug: in tlr * fix:tlr * fix Jenkines * fix: Jenkines in Documentation * minior updates * huge refactoring * full R * potential for tlr issue * updates in heavy tests * a fix for gpu in gaussian kernels * smalling tlr size * update sizes of heavy_tests * smalling size for gpu * minior changes * Huge refactoring in docs * resolve threads * fix MPI * resolve thread * updated R documentation * documentation and hardware changes * finalized documentations * minior change in Hardware * Ft test mpi mk (#6) * solve multi thread issue in MPI * Fix MPI tests with chameleon * Fixed HiCMA with MPI * update license * minior cleanings (#7) * v1.1.0 (#4) (#8) * add the pow_exp kernel and tested * all fixes * resolve threads plus some modifications * Fix cuda * fix for linking cuda * fix: hicma modifactions * try fixing Jenkines * Adding R structure * fix:add doxygen in Jenkines * add test file for pow-exp kernel * test with -fpic * some modifications for HiCMA * updates * try 2 gpu devices * back to starsh * a potential fix to doxygen * roll back * test Rcpp * Fix Jenkines * fix errors * Updated in design * updates * all release issue without src checks * adding MakeFile * Updated MPI * Documentation * fix examples tests * modeling takes pointers * example for read and write data * fix: typpo in Initialize * fix passing numbers of theta * fix: performance of gsl * fix: GPU support * fix:mspe * updated devel * R branch init * tests:add r tests * fix tests * bug: in tlr * fix:tlr * fix Jenkines * fix: Jenkines in Documentation * minior updates * huge refactoring * full R * potential for tlr issue * updates in heavy tests * a fix for gpu in gaussian kernels * smalling tlr size * update sizes of heavy_tests * smalling size for gpu * minior changes * Huge refactoring in docs * resolve threads * fix MPI * resolve thread * updated R documentation * documentation and hardware changes * finalized documentations * minior change in Hardware * Ft test mpi mk (#6) * solve multi thread issue in MPI * Fix MPI tests with chameleon * Fixed HiCMA with MPI * update license * minior cleanings (#7) --------- Co-authored-by: Sameh M. Abdulah Co-authored-by: Mahmoud Karargy * Fix P & Q * updates in R (#9) * Fix error in R * Fix using of openblas (#16) --------- Co-authored-by: Sameh M. Abdulah Co-authored-by: Mahmoud Karargy * V1.1.2 (#17) * Fixed cmake installation and add requirements in ReadME * All fixes for hicma * Modify README.md (#22) * modify README.md * more edits to README.md * more minor edits * more minor edits to the R example * fix the R code * remove empty line * debuging prints * cleaner version --------- Co-authored-by: Sameh M. Abdulah Co-authored-by: Mahmoud Karargy Co-authored-by: Sameh Abdulah <23186151+SAbdulah@users.noreply.github.com> --- src/api/ExaGeoStat.cpp | 2 ++ .../concrete/tlr/HicmaImplementation.cpp | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/api/ExaGeoStat.cpp b/src/api/ExaGeoStat.cpp index f739ef83..7abc2b46 100644 --- a/src/api/ExaGeoStat.cpp +++ b/src/api/ExaGeoStat.cpp @@ -27,6 +27,8 @@ using namespace exageostat::configurations; template void ExaGeoStat::ExaGeoStatLoadData(Configurations &aConfigurations, std::unique_ptr> &aData) { + int seed = 0; + std::srand(seed); aConfigurations.PrintSummary(); LOGGER("** ExaGeoStat data generation/loading **") // Register and create a kernel object diff --git a/src/linear-algebra-solvers/concrete/tlr/HicmaImplementation.cpp b/src/linear-algebra-solvers/concrete/tlr/HicmaImplementation.cpp index 03e8ca2b..da7e378e 100644 --- a/src/linear-algebra-solvers/concrete/tlr/HicmaImplementation.cpp +++ b/src/linear-algebra-solvers/concrete/tlr/HicmaImplementation.cpp @@ -233,10 +233,6 @@ T HicmaImplementation::ExaGeoStatMLETile(std::unique_ptr> & VERBOSE("LR: Cholesky factorization of Sigma...") START_TIMING(time_facto); -#ifdef USE_R - ((double *)HICMA_descCrk->mat)[1] = 0; -#endif - this->ExaGeoStatPotrfTile(EXAGEOSTAT_LOWER, HICMA_descCUV, 0, HICMA_descCD, HICMA_descCrk, max_rank, pow(10, -1.0 * acc));