Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec Tests for clamav milter #31

Open
edestecd opened this issue Jan 14, 2017 · 9 comments
Open

Spec Tests for clamav milter #31

edestecd opened this issue Jan 14, 2017 · 9 comments

Comments

@edestecd
Copy link
Owner

No description provided.

@edestecd
Copy link
Owner Author

@ubellavance when you get a chance let me know...

@ubellavance
Copy link

I'm setting a reminder for myself in about two months. I hope I'll have time before that.

@ubellavance
Copy link

I think I should be able to start soon. Where should I start? I looked a bit in the spec folder but couldn't totally make sense of it.

@ubellavance
Copy link

@edestecd?

@edestecd
Copy link
Owner Author

You need to add a new file: spec/classes/clamav_milter_spec.rb

Start out by copying clamav_spec.rb, then just modify to suit.
You generally want a case with the defaults and then several cases where you set common parameters and assert what you expect.

@ubellavance
Copy link

Looks rather easy. I'll give it a shot some time soon. Thanks!

@ubellavance
Copy link

Hardest part may be to rebase, though 🙁

@ubellavance
Copy link

ubellavance commented Jun 1, 2017

@edestecd I didn't have to rebase, good news. I did create the file, and added travis tests to my own repo, and it fails, but because of an unrelated reason. I know that it will probably fail on all OSs except RedHat and CentOS 7, but at least I would know if my tests work. I think I found how to define a specific OS for tests here. Does it make sense?

@ubellavance
Copy link

@edestecd?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants