Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify units #51

Open
edmundsj opened this issue Jul 4, 2022 · 0 comments
Open

Add ability to specify units #51

edmundsj opened this issue Jul 4, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@edmundsj
Copy link
Owner

edmundsj commented Jul 4, 2022

Currently, the default units for internal databases are microns. If these materials are not used, the units of length can be chosen to be anything (meters, nanometers, flargons), as Maxwell's Equations are length-invariant. However, some users may prefer to explicitly specify units for their simulation. This would allow materials dispersion to be specified in terms of the user's preferred units, and would make plots easier to interpret

Proposed Implementation

solver = Solver(stack, source, units='nm')

This would require some slight refactoring of materials lookup, but would allow future-proofing to work with materials databases outside the optical range.

@edmundsj edmundsj added the enhancement New feature or request label Jul 4, 2022
@edmundsj edmundsj added this to the Version 1.3 - Materials milestone Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant