You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are several things we can do once #101 is merged that will make the resulting code base simpler. We should choose whether and when to.
Perhaps replace the driver.data_types dictionary with a dictionary in core, directly holding the generator functions themselves, without indirecting through a string and a chain of if statements for interpreting it.
Perhaps move core.fortran_file to the utils module.
Perhaps simplify the Fortran core, the parameters.in file, and the inside of the driver by hard-coding a naming convention for the raw input files, since they are now generated anyway.
Con: Anyone who wishes to isolate the Fortran core and wrap it differently will have a less flexible object to work with.
The text was updated successfully, but these errors were encountered:
There are several things we can do once #101 is merged that will make the resulting code base simpler. We should choose whether and when to.
driver.data_types
dictionary with a dictionary incore
, directly holding the generator functions themselves, without indirecting through a string and a chain ofif
statements for interpreting it.core.fortran_file
to theutils
module.parameters.in
file, and the inside of the driver by hard-coding a naming convention for the raw input files, since they are now generated anyway.The text was updated successfully, but these errors were encountered: