Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integration] Add support for Docker runner #3732

Closed
3 tasks
pierrehilbert opened this issue Nov 9, 2023 · 5 comments
Closed
3 tasks

[Integration] Add support for Docker runner #3732

pierrehilbert opened this issue Nov 9, 2023 · 5 comments
Labels
Team:Elastic-Agent Label for the Agent team test-debt Label for missing test we need to implement Testing

Comments

@pierrehilbert
Copy link
Contributor

Issue

Describe the enhancement:

Some users are running Elastic Agent on Docker and we are not currently able to tests our different scenarios on this environment.

Describe a specific use case for the enhancement or feature:

To support testing on Docker.

Definition of done

  • Create a OSRunner for Docker
  • Update the OS support list for the runner
  • Ensure that already in place tests are working on Dockers
@pierrehilbert pierrehilbert added Team:Elastic-Agent Label for the Agent team Testing labels Nov 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@ycombinator
Copy link
Contributor

@blakerouse Would we be able to implement this issue by implementing a new InstanceProvisioner?

// InstanceProvisioner performs the provisioning of instances.
type InstanceProvisioner interface {

@cmacknz
Copy link
Member

cmacknz commented Oct 1, 2024

I think the kind runner probably covers this, unless we specifically want to test containers separate from k8s.

@cmacknz
Copy link
Member

cmacknz commented Oct 1, 2024

(I don't think there's much value in testing docker separate from k8s)

@ycombinator
Copy link
Contributor

Thanks @cmacknz. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team test-debt Label for missing test we need to implement Testing
Projects
None yet
Development

No branches or pull requests

5 participants