Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated "golang.org/x/tools/go/vcs": replace it with go list command with -json flag instead #4138

Closed
pchila opened this issue Jan 25, 2024 · 2 comments · Fixed by #5281
Closed

Remove deprecated "golang.org/x/tools/go/vcs": replace it with go list command with -json flag instead #4138

pchila opened this issue Jan 25, 2024 · 2 comments · Fixed by #5281
Labels
chore Tasks that just need to be done, they are neither bug, nor enhancements Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@pchila
Copy link
Member

pchila commented Jan 25, 2024 •
edited
Loading

In PR #3910 linter complains about the usage of vcs package in dev-tools

image

SA1019: "golang.org/x/tools/go/vcs" is deprecated: Use the go list command with -json flag instead, which implements up-to-date import path resolution behavior, module support, and includes the latest security fixes. (staticcheck)

Since this does not look like a quick fix, I am opening this issue to track the removal of deprecated vcs package
@pchila pchila added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team chore Tasks that just need to be done, they are neither bug, nor enhancements labels Jan 25, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@pchila pchila mentioned this issue Jan 25, 2024
Merged
3 tasks
@ycombinator ycombinator mentioned this issue Feb 1, 2024
Merged
3 tasks
@kruskall kruskall mentioned this issue Aug 10, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Tasks that just need to be done, they are neither bug, nor enhancements Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: drop golang.org/x/tools/go/vcs dep kruskall/elastic-agent
2 participants
@elasticmachine @pchila