Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APM config is not correctly marshaled in diagnostic files #4185

Open
pchila opened this issue Feb 2, 2024 · 3 comments
Open

APM config is not correctly marshaled in diagnostic files #4185

pchila opened this issue Feb 2, 2024 · 3 comments
Labels
bug Something isn't working Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@pchila
Copy link
Member

pchila commented Feb 2, 2024 •
edited
Loading

APM configuration is not correctly marshaled when collecting diagnostics, see https://github.com/elastic/elastic-agent/pull/3223/files#diff-fc6b455c3e3a0055095709cc4138f976720bf752acce1ac872505bcf94bf9322R100-R113

This is happening because the APMConfig struct has only config tags and doesn't specify yaml: tags to set the names correctly when marshaling objects with a yaml.Marshal (for example in diagnostics)

Setting the proper tags should fix this issue.
@pchila pchila added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team labels Feb 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@pchila
Copy link
Member Author

pchila commented Sep 11, 2024

Partially fixed in #5492 for diagnostics that are dumping elastic-agent configuration, generated structs code for Component is not fixed yet, wer'll probably need to define separate structs instead of using protobuf-generated ones

@pchila pchila mentioned this issue Sep 17, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elasticmachine @pchila