Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that we use IgnoreCommas for elastic/go-ucfg in all code paths #5265

Open
rdner opened this issue Aug 7, 2024 · 2 comments
Open
Labels
Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@rdner
Copy link
Member

rdner commented Aug 7, 2024

In all Go-based products we are using this library to parse configuration https://github.com/elastic/go-ucfg/

This library is trying to be smart about the values it finds in YAML. For example, a comma separated string gets parsed as an array, which is causing issues with password values.

We get complaints from customers, for example https://discuss.elastic.co/t/es-password-containing-comma-cant-be-passed-as-environment-variable/294450

This issue has been also reported in the library repository before, see elastic/go-ucfg#196

and it was fixed by adding the new
IgnoreCommas configuration option in this PR elastic/go-ucfg#197

It was also fixed in Elastic Agent with this PR #4436 but might not cover all the places where Elastic Agent parses configuration.

This fix was shipped with 8.14.0, see the changelog https://www.elastic.co/guide/en/fleet/8.14/release-notes-8.14.0.html

We need to make sure that all code paths in Elastic Agent and in other products are using this new configuration option.

@rdner rdner added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team labels Aug 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

No branches or pull requests

2 participants