Skip to content
This repository was archived by the owner on Mar 27, 2020. It is now read-only.

Serious flaw in usage example shown in Readme #50

Open
nelsonad opened this issue Jul 26, 2019 · 0 comments
Open

Serious flaw in usage example shown in Readme #50

nelsonad opened this issue Jul 26, 2019 · 0 comments

Comments

@nelsonad
Copy link

As described in this article, https://aspnetmonsters.com/2016/08/2016-08-27-httpclientwrong/, an application should limit the number HttpClient objects that are created and reuse it for subsequent requests. Otherwise it would open a new TCP connection for each request and it would be very easy to hit an application pools max queue length of 1000 for any website using this code as is.

The sample code in the readme should add a disclaimer describing the issue or be updated to a more complete implementation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant