Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout using push date with git submission #25

Open
alexandreMesle opened this issue Apr 8, 2022 · 1 comment
Open

Checkout using push date with git submission #25

alexandreMesle opened this issue Apr 8, 2022 · 1 comment

Comments

@alexandreMesle
Copy link

Hi everybody,

This plugin is great, and I really have to thank you because it has changed my life !

Nevertheless, I would like to discuss the fact that the grader does not take into account the push date of the git submissions.

It a quiz has a cutoff date, the grading occurs when the quiz cuts off and it's fine.

Except if you want to make adjustments of course ! If ever a teacher tries to regrade later, things can really go wrong because the git repositories can have changed. A student can make additional commits that will be taken into account by the grader.

Do you think it is possible, when regrading, to checkout to the last commit before the cutoff date ?

One related problem is that regrading can be very slow if students have made a lot of manuel Check, because each check is stored in the question history.

Regrading regrades every entry into the question history, and each of these entries gives the same grade since the same git repository is cloned and checked out to the last commit. Why not regrade just once per question and per student ?

Maybe this problem is due to moodle, and not to praktomat. In this case, why not use the push date of each manual check to checkout to a different commit of the repository history ? And them have grades that match the student progression during the exam ?

I hope I have explained the problem clearly (sorry for my poor english !). And I know this issue is very specific : you could tell me "don't regrade" and close the ticket. But it is complicated to predict everything during this kind of examination, and the possibility to to adjust the unit tests is really helpful if you want to give more relevant grades.

Thanks for reading my issue and have a good day !

@alexandreMesle
Copy link
Author

It seems that the command cmd = ['git', 'log', '-1', settings.GIT_LOG_FORMAT] (src/proforma/api_v2.py line 608) takes the last commit, and does not compare the commit date with the examination date. It could explain why it is complicated to regrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant