Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define an APK naming scheme #4232

Closed
Aquathing opened this issue Feb 4, 2025 · 3 comments
Closed

Define an APK naming scheme #4232

Aquathing opened this issue Feb 4, 2025 · 3 comments
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@Aquathing
Copy link

Your use case

What would you like to do?

I want to add Element X to the Obtanium crowdsourced app config repository. This repo contains JSON configurations for Obtanium which teach it how to download apps from their official release sources.

I see that the naming scheme from the universal package has changed from numberversion.apk to numberversion-universal.apk. Can we declare scheme as official so that if it changes it is considered a breaking change?

Why would you like to do it?

Obtanium needs to know which apk to select from the release page. Having an official scheme ensures that it doesn't break.

Have you considered any alternatives?

No response

Additional context

No response

Are you willing to provide a PR?

No

@Aquathing Aquathing added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Feb 4, 2025
@bmarty
Copy link
Member

bmarty commented Feb 5, 2025

OK, let's stick to numberversion.apk, which avoid to do a manual renaming on our side.

@bmarty bmarty closed this as completed Feb 5, 2025
@bmarty
Copy link
Member

bmarty commented Feb 5, 2025

note: I have renamed the apk in https://github.com/element-hq/element-x-android/releases/tag/v25.02.0 to follow the naming scheme

@Aquathing
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

No branches or pull requests

2 participants