You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.
when adopting ember-cli-eslint you'll likely end up with a lot of warnings/errors and in turn you will
a) change your code a lot
b) change .eslintrc quite a bit to match your coding style/your globals/etc.
a) already rebuilds the application just fine, if you only change the .eslintrc (b)) you cannot immediately see if tests now pass. ... that would be nice though 👍
Best regards,
Dominik
The text was updated successfully, but these errors were encountered:
I have not got round to looking at this yet, I'm sorry about that.
Certainly I like the idea and certainly not against it, just have not had time to take a look. It isn't something complex however the outcome of some of the other outstanding issues might impact this one.
For example: if #13 and #14 are still causing issues the broccoli-lint-eslint might have to be changed as to how it calls the code (essentially reimplementing parts of ESLint so it can cope with nested .eslintrc files) which would be worth exposing as an API to solve this if it is needed.
So yeah, I thought I would chime in so you know I am not ignoring you.
we currently don't watch the root of the project, largely because tmp and node_modules are present. I think with broccoli 1.0 allowing us to move the tmp dir to system temp we may be able to do this performantly. Alternatively, we could poll or just watch the root and deal with performance issues if they arise.
Hey,
when adopting ember-cli-eslint you'll likely end up with a lot of warnings/errors and in turn you will
a) change your code a lot
b) change .eslintrc quite a bit to match your coding style/your globals/etc.
a) already rebuilds the application just fine, if you only change the .eslintrc (b)) you cannot immediately see if tests now pass. ... that would be nice though 👍
Best regards,
Dominik
The text was updated successfully, but these errors were encountered: