Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkTo and Input don't support arbitrary attributes in <3.10 #120

Open
elwayman02 opened this issue Jun 17, 2020 · 0 comments
Open

LinkTo and Input don't support arbitrary attributes in <3.10 #120

elwayman02 opened this issue Jun 17, 2020 · 0 comments

Comments

@elwayman02
Copy link

elwayman02 commented Jun 17, 2020

The built-in LinkTo component provided by this polyfill doesn't pass through arbitrary attributes. For example:

<LinkTo @route='/' data-some-attribute>Index</LinkTo>

renders as

<a href="/">Index</a>

but should be

<a href="/" data-some-attribute="">Index</a>

The polyfill rewrites LinkTo to curly invocation but doesn't put the arbitrary attributes anyway.

The same thing is true for <Input>. Both of these built-ins allow arbitrary attributes in 3.10+, but the polyfill did not maintain that support.

To solve this, we need a similar approach to the Component runtime polyfill (that runs for <2.12).

@elwayman02 elwayman02 changed the title LinkTo doesn't support arbitrary attributes in <3.10 LinkTo and Input don't support arbitrary attributes in <3.10 Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant