Fix push notification bug #168
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Generated by 🚫 Danger Swift against aafc5c4 |
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
- Coverage 90.43% 89.87% -0.56%
==========================================
Files 422 428 +6
Lines 28491 29173 +682
==========================================
+ Hits 25766 26220 +454
- Misses 2725 2953 +228
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes #113, where push notifications were sometimes not reaching the app when users did not implement
UNUserNotificationCenterDelegatemethods.Description
We’ve introduced conditional logic for proxying
UNUserNotificationCenterDelegatemethods:To account for cases where users don't implement
UNUserNotificationCenterDelegatemethods, we have added a fallback swizzling ofUIApplicationDelegate.application(_:didReceiveRemoteNotification:fetchCompletionHandler:). This ensures that notifications are still captured by the SDK, even when no delegate is explicitly handling them.Warning
This does not handle cases where an app receives push notifications but does not implement any handling logic (e.g., neither
UNUserNotificationCenterDelegatemethods norUIApplicationDelegate.application(_:didReceiveRemoteNotification:fetchCompletionHandler:)). In such scenarios, push notifications will still be received by iOS but we'll not be able to capture them.