Skip to content

Commit

Permalink
Avoid the term daemon since we use a regular background thread
Browse files Browse the repository at this point in the history
  • Loading branch information
AdrianSosic committed Feb 19, 2025
1 parent 2186ecf commit 19520e4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
- Acquisition function indicator `is_mc` has been removed in favor of new indicators
`supports_batching` and `supports_pending_experiments`
- Telemetry now runs in a daemon thread
- Telemetry now runs in a separate thread

### Fixed
- Incorrect optimization direction with `PSTD` with a single minimization target
Expand Down
6 changes: 3 additions & 3 deletions baybe/telemetry/_telemetry.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,8 @@ def test_connection() -> Exception | None:
return ex


def daemon_task() -> None:
"""The telemetry logic to be executed in the daemon thread.""" # noqa
def telemetry_task() -> None:
"""The telemetry logic to be executed in a background thread.""" # noqa
# Telemetry is inactive
if not is_enabled():
transmission_queue.close()
Expand Down Expand Up @@ -238,4 +238,4 @@ def submit_scalar_value(instrument_name: str, value: int | float) -> None:

tools = TelemetryTools()
transmission_queue = CloseableQueue()
Thread(target=daemon_task).start()
Thread(target=telemetry_task).start()

0 comments on commit 19520e4

Please sign in to comment.