Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support podAnnotations #663

Open
DanLindeman opened this issue Nov 4, 2021 · 0 comments
Open

Support podAnnotations #663

DanLindeman opened this issue Nov 4, 2021 · 0 comments

Comments

@DanLindeman
Copy link

DanLindeman commented Nov 4, 2021

Environment

  • OS: N/A
  • Erlang/OTP: N/A
  • EMQ: N/A

Description

The helm chart could allow users to annotate the individual pods by exposing a podAnnotations stanza in values.yaml which would be consumed by the StatefulSet definition. This is done in other popular charts (for example, timescaledb), and would allow users to leverage annotations. For context, my personal use-case is for adding datadog autodiscovery annotations -- which this feature would enable.

Fix could be implemented by adding the following here:

{{- if .Values.podAnnotations }}
      annotations:
{{ toYaml .Values.podAnnotations | indent 8 }}
{{- end }}

Update: the solution will likely have to work in tandem with the support for recreatePods -- so it may end up being more like the following:

      {{- if or .Values.recreatePods .Values.podAnnotations }}
      annotations:
      {{- end }}
      {{- if .Values.recreatePods }}
        checksum/config: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum | quote }}
      {{- end }}
{{- if .Values.podAnnotations }}
{{ toYaml .Values.podAnnotations | indent 8 }}
{{- end }}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant