Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react] Split back rows for v18 #6680

Open
euipolv opened this issue Jan 31, 2025 · 7 comments
Open

[react] Split back rows for v18 #6680

euipolv opened this issue Jan 31, 2025 · 7 comments
Labels
bug Something isn't working

Comments

@euipolv
Copy link

euipolv commented Jan 31, 2025

Link to product page on endoflife.date

react

Details of incorrect and correct details you have found

They version key of react has changed from version 18 to version 19.
E.g., Versions from 18.0 to 18.3 disappeared.
Because we are documenting our systems also querying via APIs the keys of EndOflife, we would need they to be permanent, as it happens (if I am not wrong) for the other EOL products.

What is the source website for the product and for its version information?

React changelog

Additional context

Many thanks for your incredible work!!!
Kind regards,
Lorenzo

@euipolv euipolv added the bug Something isn't working label Jan 31, 2025
Copy link

welcome bot commented Jan 31, 2025

Thank you for opening your first issue here 👍. Be sure to follow the issue template if you chose one.

@captn3m0
Copy link
Member

As we have limited maintenance resources, and for usability reasons - we collapse older releases of some products where it makes sense. This isn't just for React, we regularly collapse older release cycles on other products as well (#1639 for eg.)

In the case of react, only the highest major's minors are considered supported and will be tracked. Prior releases only support the last minor, which is collapsed to a single row as such, since it doesn't result in any loss of information.

In your case, you should switch to a better matching algorithm.

@captn3m0 captn3m0 changed the title Change of the version key for the "react" product? [react] Split back rows for v18 Jan 31, 2025
@euipolv
Copy link
Author

euipolv commented Feb 3, 2025

Dear @captn3m0 ,
Thanks a lot for your kind and very appreciated answer, we will adapt our matching algorithm as you suggested.
But please let me ask for more information, as I am not sure I have understood correctly, so please accept my apologies since now, if this is the case.

I have checked the PHP versioning of the example and, if I am not wrong, the keys of the old releases are also maintained with major and minor version (e.g. 5.4 is an old version and it is maintained in the API).

Instead, for React, the keys with the minor versions are deleted from the APIs and only the major version is maintained (e.g. this does not work anymore: https://endoflife.date/api/react/18.3.json, and this one, which was not available till the version 19, works: https://endoflife.date/api/react/18.json) .

At the same time, the latest release maintains the minor version key but not the one of the major version only (e.g. this works: https://endoflife.date/api/react/19.0.json, but this does not work: https://endoflife.date/api/react/19.json).

Aa a result, we must change our documentation metadata any time there is a new version of react, due to fact that the past minor versions disappeared from the API. I.e., we must change all the metadata from version 18.3/18.2 to 18.

As a solution we could maintain only the major version for all the releases, but in this case we would need it also for the newest release. Do you think it will be possibile to have the latest major version for the last release one, too? E.g. https://endoflife.date/api/react/19.json.

Thanks a lot,
Kind regards,
Lorenzo

@BiNZGi
Copy link
Member

BiNZGi commented Feb 3, 2025

You are right, it should be 19.json instead of 19.0.json. I filed PR #6692 to update.

You can already check the change in the API in the preview: https://deploy-preview-6692--endoflife-date.netlify.app/api/react/19.json

@euipolv
Copy link
Author

euipolv commented Feb 3, 2025

You are right, it should be 19.json instead of 19.0.json. I filed PR #6692 to update.

You can already check the change in the API in the preview: https://deploy-preview-6692--endoflife-date.netlify.app/api/react/19.json

Many thanks @BiNZGi ! The preview works for me! Very appreciated!
Kind regards,
Lorenzo

@euipolv
Copy link
Author

euipolv commented Feb 5, 2025

Dear @BiNZGi ,
Do you know +/- when the change in the API will be ready in prod?

Thanks a lot,
Kind regards,
Lorenzo

@BiNZGi
Copy link
Member

BiNZGi commented Feb 5, 2025

Hard to say because there is a discussion in #6692 ongoing regarding proper naming of the cycles. We have to agree there to merge or close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants