From a43efc8a2301c4caf760889f2e88ab3ab72b60b2 Mon Sep 17 00:00:00 2001 From: Eoin O'Brien Date: Tue, 25 Jun 2024 01:02:30 +0100 Subject: [PATCH] Fix no outbound green line trams. Brides glen name should have no apostrophe --- .../Models/StationForcastTests.cs | 21 ++++++++++++++++++- LuasAPI.NET/StationInformation/Stations.json | 8 +++---- 2 files changed, 24 insertions(+), 5 deletions(-) diff --git a/LuasAPI.NET.Tests/Models/StationForcastTests.cs b/LuasAPI.NET.Tests/Models/StationForcastTests.cs index 83c7ae9..d73936b 100644 --- a/LuasAPI.NET.Tests/Models/StationForcastTests.cs +++ b/LuasAPI.NET.Tests/Models/StationForcastTests.cs @@ -33,7 +33,7 @@ public void CreateStationForecastFromRealTimeInfo_StationsIsNull_ThrowsArgumentE } [Fact] - public void CreateStationForecastFromRealTimeInfo_() + public void CreateStationForecastFromRealTimeInfo_1() { UnitTestStationInformationLoader loader = new UnitTestStationInformationLoader(); loader.AddStations(new Station() { Abbreviation = "STS", Name = "St. Stephen's Green", IsInUse = true }); @@ -51,6 +51,25 @@ public void CreateStationForecastFromRealTimeInfo_() Assert.Single(forecast.OutboundTrams); } + [Fact] + public void CreateStationForecastFromRealTimeInfo_2() + { + UnitTestStationInformationLoader loader = new UnitTestStationInformationLoader(); + loader.AddStations(new Station() { Abbreviation = "STI", Name = "Stillorgan", IsInUse = true }); + loader.AddStations(new Station() { Abbreviation = "BRI", Name = "Bride's Glen", IsInUse = true }); + loader.AddStations(new Station() { Abbreviation = "SAN", Name = "Sandyford", IsInUse = true }); + + Stations stations = new Stations(loader); + + RealTimeInfo realTimeInfo = CreateRealTimeInfoFromXml("Green Line services operating normally"); + + StationForecast forecast = StationForecast.CreateStationForecastFromRealTimeInfo(realTimeInfo, stations); + + Assert.Equal(realTimeInfo.Stop, forecast.Station.Name); + Assert.Empty(forecast.InboundTrams); + Assert.Single(forecast.OutboundTrams); + } + private RealTimeInfo CreateRealTimeInfoFromXml(string xml) { XmlSerializer serializer = new XmlSerializer(typeof(RealTimeInfo)); diff --git a/LuasAPI.NET/StationInformation/Stations.json b/LuasAPI.NET/StationInformation/Stations.json index 1a77c2f..f463852 100644 --- a/LuasAPI.NET/StationInformation/Stations.json +++ b/LuasAPI.NET/StationInformation/Stations.json @@ -1,4 +1,4 @@ -{ +{ "DEP": { "abbreviation": "DEP", "name": "Depot", @@ -5190,9 +5190,9 @@ }, "BRI": { "abbreviation": "BRI", - "name": "Bride's Glen", + "name": "Brides Glen", "irishName": "Gleann Bhríde", - "pronunciation": "bride's glen", + "pronunciation": "brides glen", "line": "Green", "hasParking": false, "hasCycleParking": false, @@ -5258,4 +5258,4 @@ } } } -} \ No newline at end of file +}