fix transfer of vacation entitlements

Author: Erik Porsche

app/Actions/TransferVacationEntitlement.php

@@ -21,7 +21,7 @@ public function transfer(User $employee, $vacationEntitlementId)
         $vacationEntitlementToBeTransferred = VacationEntitlement::findOrFail($vacationEntitlementId);
 
         //fetch a possible vacation entitlement candiate
-        $useExistingVacationEntitlement = VacationEntitlement::where('ends_at', $vacationEntitlementToBeTransferred->end_of_transfer_period)->first();
+        $useExistingVacationEntitlement = $employee->vacationEntitlements()->where('ends_at', $vacationEntitlementToBeTransferred->end_of_transfer_period)->first();
         if (!empty($useExistingVacationEntitlement)) {
             $vacationEntitlementToBeTransferred->transferVacationDays($useExistingVacationEntitlement, [
                 'days' => $useExistingVacationEntitlement->days->plus($vacationEntitlementToBeTransferred->daysTransferrable())