Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E tests for queue options #10141

Open
jonathan-eq opened this issue Feb 24, 2025 · 0 comments · May be fixed by #10147
Open

Add E2E tests for queue options #10141

jonathan-eq opened this issue Feb 24, 2025 · 0 comments · May be fixed by #10147
Assignees
@jonathan-eq
Labels
release-notes:improvement Automatically categorise as improvement in release notes

Comments

@jonathan-eq
Copy link
Contributor

There was an issue where one of the queue options for the slurm driver were never propagated (#10124). We have no realistic end-to-end tests for this, which would have caught this.
The test should run poly_example, and make sure the queue_options are propagated all the way from ert config to the shell command.
@jonathan-eq jonathan-eq self-assigned this Feb 24, 2025
@jonathan-eq jonathan-eq added the release-notes:improvement Automatically categorise as improvement in release notes label Feb 24, 2025
@jonathan-eq jonathan-eq moved this to In Progress in SCOUT Feb 24, 2025
@jonathan-eq jonathan-eq linked a pull request Feb 25, 2025 that will close this issue
Open
9 tasks
@jonathan-eq jonathan-eq moved this from In Progress to Ready for Review in SCOUT Feb 25, 2025
@jonathan-eq jonathan-eq moved this from Ready for Review to Reviewed in SCOUT Feb 27, 2025
@jonathan-eq jonathan-eq moved this from Reviewed to Ready for Review in SCOUT Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathan-eq jonathan-eq

Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
SCOUT
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test for the propagation of queue_options from ertconfig to cluster jonathan-eq/ert
1 participant
@jonathan-eq