Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation says task removes files from deps.json, but it doesn't #7

Open
wjk opened this issue Aug 7, 2019 · 2 comments
Open

Comments

@wjk
Copy link

wjk commented Aug 7, 2019

What the title says, really. Without this feature, trimming a self-contained .NET Core project results in a project that won't run. As far as I can tell, this feature isn't actually implemented anywhere. Could this please be fixed? Thanks!

@ericstj
Copy link
Owner

ericstj commented Nov 7, 2019

The targets do this by setting the _ConflictPackageFiles item which the SDK should honor when generating the deps file. Can you share a repro that's not running along with the SDK version and I'll take a closer look.

@wjk
Copy link
Author

wjk commented Nov 23, 2019

@ericstj I think I've found the problem. This error only occurs when the project being trimmed is ran through a Desktop Bridge project (*.wapproj). Apparently the Desktop Bridge targets cause the deps.json file to be overwritten with a pristine copy that references the trimmed files. When I build and run the project directly from its OutputPath, it works just fine. Unfortunately, due to the complexity and general opaqueness of the UWP/Desktop Bridge build process, I cannot debug this issue any further. Could you look into this for me? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@wjk @ericstj and others