Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FoxyLink] Troubles with copying links #71

Open
TinyTrbl opened this issue Jun 23, 2019 · 3 comments
Open

[FoxyLink] Troubles with copying links #71

TinyTrbl opened this issue Jun 23, 2019 · 3 comments
Labels

Comments

@TinyTrbl
Copy link

Hello i have troubles with copying links.

For example:

  1. i select "erosman/support" text from the top of this github page (supposed to be 2 links, right?)
  2. select Copy Selected to Clipboard
  3. paste it into TXT file,
  4. then it pastes only plain text "erosman/support" but not the links.

It is something wrong on my side, a bug maybe, or i just don't understand how to copy... links?

@erosman
Copy link
Owner

erosman commented Jun 23, 2019

Hello

I did the same and didn't see any problem.

  • Select to text "erosman/support" above
  • "Copy Selected to Clipboard"
  • paste into a text file
    result:
https://github.com/erosman
https://github.com/erosman/support

NOTE: If you are copying into Notepad in Windows, it doesn't recognise "\n" as new line and displays 2 links in one line i.e.
https://github.com/erosmanhttps://github.com/erosman/support

AFAIK Notepad is the only app like that. Wordpad, MS Word and other apps and other operating systems (e.g. iOS, Linux) recognise "\n" as new line.

I have altered the code in some of my other addons to use "\r\n" on Windows to make it easier (for Notepad). I will do that in FoxyLink as well in the next upgrade.

@erosman erosman added the feature request 💡 New feature or request label Jun 23, 2019
@TinyTrbl
Copy link
Author

Hey! I found a source of my problems...

If you have dom.event.clipboardevents.enabled as false in your Firefox config, then you will get my results. It was non issue for XUL addons, but i suppose it works differently for Web extensions.

I even found that it can break Google docs and Facebook copy/paste features: pyllyukko/user.js#287

I don’t want to enable this feature for my own reasons, but somehow you may be interested in this information or you may want to fix it... Who knows. Anyway, thanks for your time.

@erosman
Copy link
Owner

erosman commented Jun 23, 2019

I see ... I came across this issue once before. WebExtension API will prevent Clipboard access if dom.event.clipboardevents.enabled is set to false.

Firefox 63+ introduced a new Clipboard API which could be the answer. I am already using it in my other addons but FoxyLink hasn't been updated for a while. I will add it to FoxyLink for the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants