Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-postgres: Set application_name param #2449

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

willdonnelly
Copy link
Member

@willdonnelly willdonnelly commented Feb 25, 2025

Description:

This means we show up like this in pg_stat_replication:

postgres=> SELECT * FROM pg_stat_replication;
-[ RECORD 1 ]----+------------------------------
pid              | 36917
usesysid         | 16540
usename          | flow_capture
application_name | estuary_flow
client_addr      | 99.27.226.225
client_hostname  |
client_port      | 40560
backend_start    | 2025-02-25 16:40:03.981342+00
[...]

Currently the application_name field is entirely blank, so it seems like having anything at all there is a clear win. We might consider making it customizable or filing in the capture task name in the future, but for now this is better than nothing.


This change is Reviewable

@willdonnelly willdonnelly added the change:unplanned Unplanned change, useful for things like doc updates label Feb 25, 2025
@willdonnelly willdonnelly requested a review from a team February 25, 2025 16:43
Copy link
Member

@Alex-Bair Alex-Bair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like there is a small test updated needed.

@willdonnelly
Copy link
Member Author

looks like there is a small test updated needed

Huh, I completely forgot we had a test covering that.

This means we show up like this in pg_stat_replication:

    postgres=> SELECT * FROM pg_stat_replication;
    -[ RECORD 1 ]----+------------------------------
    pid              | 36917
    usesysid         | 16540
    usename          | flow_capture
    application_name | estuary_flow
    client_addr      | 99.27.226.225
    client_hostname  |
    client_port      | 40560
    backend_start    | 2025-02-25 16:40:03.981342+00
    [...]

Currently the `application_name` field is entirely blank, so it
seems like having anything at all there is a clear win. We might
consider making it customizable or filing in the capture task
name in the future, but for now this is better than nothing.
@willdonnelly willdonnelly force-pushed the wgd/postgres-application-name-20250225 branch from c3c7053 to dd5c44b Compare February 25, 2025 17:03
@willdonnelly willdonnelly merged commit 49f5235 into main Feb 25, 2025
53 of 56 checks passed
@willdonnelly willdonnelly deleted the wgd/postgres-application-name-20250225 branch February 25, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:unplanned Unplanned change, useful for things like doc updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants