materialize-boilerplate: fix staged files cleanup again #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In f4a82c4 a partial fix was implemented to prevent attempts to cleanup the same files again when a binding had data for one but not a subsequent transaction. That change fixed that issue, but it also made it so that staged files just never got cleaned up, because `f.started` is set to `false` by `f.flush()`, which is always called before the cleanup. A complete fix is here, which clears out the list of uploaded files after sending them off for deletion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In f4a82c4 a partial fix was implemented to prevent attempts to cleanup the same files again when a binding had data for one but not a subsequent transaction.
That change fixed that issue, but it also made it so that staged files just never got cleaned up, because
f.startedis set tofalsebyf.flush(), which is always called before the cleanup.A complete fix is here, which clears out the list of uploaded files after sending them off for deletion.
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is