Fix HTTP client reading non-ascii journal content #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switching more tests to snapshots to test a wider range of things all at once Getting some tests updated to handle the new control plane
travjenkins
changed the title
The grpc gateway returns journal content as a base64-encoded string. Previously, we had been using `atob` to decode this, but that function does not work if the decoded content contains any byte values larger than 0x7f, because of course we can't have nice things in JS. So this adds one of those looks-insane-but-actually-works workarounds to make base64 decoding work properly with arbitrary utf-8 data.
psFried
changed the title
travjenkins
commented
Aug 9, 2024
| @@ -50,7 +50,17 @@ export function decodeContent() { | |||
| transform(value, controller) { | |||
| // Base64 decode the `content` field and send it as a chunk. | |||
| if (value.content?.length) { | |||
| controller.enqueue(atob(value.content)); | |||
| // The `atob` function does not work properly if the decoded content contains any byte | |||
There was a problem hiding this comment.
I know we are not running in node but in the UI we have stopped using atob and btoa and replaced with 'Bufferand.toString('base64')`
There was a problem hiding this comment.
I don't mind trying this out on my local and running the tests
There was a problem hiding this comment.
Never mind - as that will be a pain polyfilling Node stuff.
kiahna-tucker
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#46
Fixes
Updated tests to work with recent control plane changes
...tbd
Tests
Added content read tests that include Arabic in the messages. These tests are failing until we implement a fix. Also, noticed that in the printing of the snapshot the string that contains Arabic seems to get flipped. Not sure if this is Deno being clever to render RTL.
Notes
ShardClient.list task selector testis failing locally when checking forPRIMARYas the status. It is failing due to this error: