Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew formula broken since 0.8.10 #13153

Open
cameel opened this issue Jun 15, 2022 · 4 comments
Open

Homebrew formula broken since 0.8.10 #13153

cameel opened this issue Jun 15, 2022 · 4 comments
Labels
bug 🐛 low impact Changes are not very noticeable or potential benefits are limited. medium effort Default level of effort must have Something we consider an essential part of Solidity 1.0. testing 🔨

Comments

@cameel
Copy link
Member

cameel commented Jun 15, 2022

Description

We maintain a custom Homebrew formula to build Solidity on macOS: solidity.rb. Since at least 0.8.10 we've been having various build issues in CI so the formula does not pass tests. It may or may not be broken on real systems. Solving these requires some debugging, preferably by someone with a mac.

Fixing this is not urgent since this affects only 0.8.x and for that version there's an official Homebrew formula. It will become an issue once we release 0.9.0 and Homebrew updates to that.

Steps to Reproduce

I recommend looking at CI output of job 238 from the PR for 0.8.14.

For reference, older PR with failed runs (though they're no longer relevan):

  • 0.8.10 - especially this one has some earlier discussion about the issues.
  • 0.8.12
  • 0.8.13
@cameel cameel added this to the 0.9.0 milestone Jun 15, 2022
@ekpyron
Copy link
Member

ekpyron commented Jun 16, 2022

ethereum/homebrew-ethereum#313, our most recent attempt, has fixed most issues, but the 0.4 series build still fails (see https://app.circleci.com/pipelines/github/ethereum/homebrew-ethereum/225/workflows/4358a1b1-2d43-4f32-92b7-be474226bbcb/jobs/242).

I'm pretty sure this will end up requiring a non-trivial source patch to build properly. That would be easiest to determine by someone with an actual osx system at hand.

@cameel cameel added selected for development It's on our short-term development medium effort Default level of effort low impact Changes are not very noticeable or potential benefits are limited. must have Something we consider an essential part of Solidity 1.0. and removed selected for development It's on our short-term development labels Sep 12, 2022
@cameel cameel removed this from the 0.9.0 milestone Sep 12, 2022
@cameel
Copy link
Member Author

cameel commented Feb 2, 2023

Related PR:ethereum/homebrew-ethereum#319

@nikola-matic
Copy link
Collaborator

ethereum/homebrew-ethereum#313, our most recent attempt, has fixed most issues, but the 0.4 series build still fails (see https://app.circleci.com/pipelines/github/ethereum/homebrew-ethereum/225/workflows/4358a1b1-2d43-4f32-92b7-be474226bbcb/jobs/242).

I'm pretty sure this will end up requiring a non-trivial source patch to build properly. That would be easiest to determine by someone with an actual osx system at hand.

I could pair up with @r0qs to give this a go, since I've got an OSX machine at home. We could use this as an investigation of sorts to see if it's even worthwhile investing time into this.

@cameel
Copy link
Member Author

cameel commented Feb 2, 2023

If you want to try, sure. Never hurts to try and if you actually manage to fix it, that's one less problem we have to think about. Just don't spend too much time on it because it's pretty low priority. These formulas have been broken for a while now and no one really complained. Probably no one builds older compilers from source on mac and for the latest one the official formula in Homebrew works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 low impact Changes are not very noticeable or potential benefits are limited. medium effort Default level of effort must have Something we consider an essential part of Solidity 1.0. testing 🔨
Projects
None yet
Development

No branches or pull requests

3 participants