From 075ec3418902a47f3e74b95923fa17b7bb1f7484 Mon Sep 17 00:00:00 2001 From: Adam Sachs Date: Mon, 22 Apr 2024 09:45:41 -0400 Subject: [PATCH 1/2] add a System.vendor_deleted_date property --- src/fideslang/models.py | 4 ++++ tests/fideslang/test_models.py | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/fideslang/models.py b/src/fideslang/models.py index 1f96de9..6d38028 100644 --- a/src/fideslang/models.py +++ b/src/fideslang/models.py @@ -5,6 +5,7 @@ """ from __future__ import annotations +from datetime import datetime from enum import Enum from typing import Any, Dict, List, Optional, Union @@ -946,6 +947,9 @@ class System(FidesModel): previous_vendor_id: Optional[str] = Field( description="If specified, the unique identifier for the vendor that was previously associated with this system." ) + vendor_deleted_date: Optional[datetime] = Field( + description="The deleted date of the vendor that's associated with this system." + ) dataset_references: List[FidesKey] = Field( default_factory=list, description="Referenced Dataset fides keys used by the system.", diff --git a/tests/fideslang/test_models.py b/tests/fideslang/test_models.py index eae3327..249ef01 100644 --- a/tests/fideslang/test_models.py +++ b/tests/fideslang/test_models.py @@ -1,3 +1,5 @@ +from datetime import datetime + from pytest import mark, raises from fideslang import DataFlow, Dataset, Organization, PrivacyDeclaration, System @@ -371,6 +373,7 @@ def test_expanded_system(self): ) ], vendor_id="gvl.1", + vendor_deleted_date=datetime.now(), dataset_references=["test_fides_key_dataset"], processes_personal_data=True, exempt_from_privacy_regulations=False, @@ -504,4 +507,3 @@ def test_dataset_collection_skip_processing(self): class TestDataUse: def test_minimal_data_use(self): assert DataUse(fides_key="new_use") - From 69e3a4700f40d814fd4f137dbd81f224a351f75c Mon Sep 17 00:00:00 2001 From: Adam Sachs Date: Mon, 6 May 2024 08:26:05 -0400 Subject: [PATCH 2/2] update changelog --- CHANGELOG.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 705cb26..46bc459 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,7 +14,13 @@ The types of changes are: - `Fixed` for any bug fixes. - `Security` in case of vulnerabilities. -## [Unreleased](https://github.com/ethyca/fideslang/compare/3.0.0...main) +## [Unreleased](https://github.com/ethyca/fideslang/compare/3.0.1...main) + +## [3.0.1](https://github.com/ethyca/fideslang/compare/3.0.0...3.0.1) + +### Added + +- Added a `vendor_deleted_date` field to the `System` model [#10](https://github.com/ethyca/fideslang/pull/10) ## [3.0.0](https://github.com/ethyca/fideslang/compare/2.2.2...3.0.0)