Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated String.prototype.substr() in robot-name.test.ts #1416

Closed
Ak5cel opened this issue Jan 19, 2024 · 1 comment · Fixed by #1417
Closed

Deprecated String.prototype.substr() in robot-name.test.ts #1416

Ak5cel opened this issue Jan 19, 2024 · 1 comment · Fixed by #1417

Comments

@Ak5cel
Copy link
Contributor

Ak5cel commented Jan 19, 2024

There's currently 4 instances of String.prototype.substr() in robot-name.test.ts. It's been deprecated, so it could be refactored to use String.prototype.slice() instead.

const alpha1 = name1.substr(0, 2)
const alpha2 = name2.substr(0, 2)
const num1 = Number(name1.substr(2, 3))
const num2 = Number(name2.substr(2, 3))

Wouldn't mind making a PR for it as a first issue if it were to be changed :)

Copy link
Contributor

Hello. Thanks for opening an issue on Exercism 🙂

At Exercism we use our Community Forum, not GitHub issues, as the primary place for discussion. That allows maintainers and contributors from across Exercism's ecosystem to discuss your problems/ideas/suggestions without them having to subscribe to hundreds of repositories.

This issue will be automatically closed. Please use this link&category=typescript ) to copy your GitHub Issue into a new topic on the forum, where we look forward to chatting with you!

If you're interested in learning more about this auto-responder, please read this blog post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant