Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for the edge case where the value is an empty string, two-fer #1429

Closed
wants to merge 1 commit into from
Closed

Add a test for the edge case where the value is an empty string, two-fer #1429

wants to merge 1 commit into from

Conversation

santi020k
Copy link

Although it's a very simple exercise, during a mentoring discussion, I found it interesting to consider the possibility of having this additional test, as it's a scenario that could happen in real life where a user might try to pass an empty string value. It's a very simple change; I just added an edge case to the two-fer tests. Feel free to reject this PR if you deem it necessary.

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Feb 25, 2024
@santi020k santi020k deleted the two-fer-edge-case branch February 25, 2024 04:31
@SleeplessByte
Copy link
Member

Thank you for the PR.

We're not going to complicate two-fer, but discussing things like this during mentoring sessions is excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants