From 2e49f6348ea09ed933521b0268d9a8767ea3d40f Mon Sep 17 00:00:00 2001 From: Will Schurman Date: Thu, 8 Feb 2024 12:38:16 -0800 Subject: [PATCH] Revert "feat(eas-cli): expose expo export dev flag as an option in eas update (#2050)" (#2214) --- CHANGELOG.md | 2 ++ packages/eas-cli/src/commands/update/index.ts | 12 ++---------- packages/eas-cli/src/project/publish.ts | 5 ----- 3 files changed, 4 insertions(+), 15 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1768b02574..0392501539 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,8 @@ This is the log of notable changes to EAS CLI and related packages. ### ๐Ÿ› Bug fixes +- Revert expose expo export dev flag as an option in eas update. ([#2214](https://github.com/expo/eas-cli/pull/2214) by [@wschurman](https://github.com/wschurman)) + ### ๐Ÿงน Chores - Upgrade [`eas-build`](https://github.com/expo/eas-build) dependencies. ([#2223](https://github.com/expo/eas-cli/pull/2223) by [@expo-bot](https://github.com/expo-bot)) diff --git a/packages/eas-cli/src/commands/update/index.ts b/packages/eas-cli/src/commands/update/index.ts index 8d2c4536f8..20d678a5f6 100644 --- a/packages/eas-cli/src/commands/update/index.ts +++ b/packages/eas-cli/src/commands/update/index.ts @@ -56,7 +56,6 @@ import { maybeWarnAboutEasOutagesAsync } from '../../utils/statuspageService'; type RawUpdateFlags = { auto: boolean; - dev: boolean; branch?: string; channel?: string; message?: string; @@ -75,7 +74,6 @@ type RawUpdateFlags = { type UpdateFlags = { auto: boolean; - dev: boolean; platform: ExpoCLIExportPlatformFlag; branchName?: string; channelName?: string; @@ -136,10 +134,6 @@ export default class UpdatePublish extends EasCommand { default: 'all', required: false, }), - dev: Flags.boolean({ - description: 'Publish a development bundle', - default: false, - }), auto: Flags.boolean({ description: 'Use the current git branch and commit message for the EAS branch and update message', @@ -165,7 +159,6 @@ export default class UpdatePublish extends EasCommand { auto: autoFlag, platform: platformFlag, channelName: channelNameArg, - dev, updateMessage: updateMessageArg, inputDir, skipBundler, @@ -234,7 +227,7 @@ export default class UpdatePublish extends EasCommand { if (!skipBundler) { const bundleSpinner = ora().start('Exporting...'); try { - await buildBundlesAsync({ projectDir, inputDir, dev, exp, platformFlag, clearCache }); + await buildBundlesAsync({ projectDir, inputDir, exp, platformFlag, clearCache }); bundleSpinner.succeed('Exported bundle(s)'); } catch (e) { bundleSpinner.fail('Export failed'); @@ -547,7 +540,7 @@ export default class UpdatePublish extends EasCommand { private sanitizeFlags(flags: RawUpdateFlags): UpdateFlags { const nonInteractive = flags['non-interactive'] ?? false; - const { auto, branch: branchName, channel: channelName, dev, message: updateMessage } = flags; + const { auto, branch: branchName, channel: channelName, message: updateMessage } = flags; if (nonInteractive && !auto && !(updateMessage && (branchName || channelName))) { Errors.error( '--branch and --message, or --channel and --message are required when updating in non-interactive mode unless --auto is specified', @@ -576,7 +569,6 @@ export default class UpdatePublish extends EasCommand { auto, branchName, channelName, - dev, updateMessage, inputDir: flags['input-dir'], skipBundler: flags['skip-bundler'], diff --git a/packages/eas-cli/src/project/publish.ts b/packages/eas-cli/src/project/publish.ts index 7c047a12f1..0122a3268d 100644 --- a/packages/eas-cli/src/project/publish.ts +++ b/packages/eas-cli/src/project/publish.ts @@ -185,14 +185,12 @@ export async function buildBundlesAsync({ exp, platformFlag, clearCache, - dev = false, }: { projectDir: string; inputDir: string; exp: Pick; platformFlag: ExpoCLIExportPlatformFlag; clearCache?: boolean; - dev?: boolean; }): Promise { const packageJSON = JsonFile.read(path.resolve(projectDir, 'package.json')); if (!packageJSON) { @@ -210,7 +208,6 @@ export async function buildBundlesAsync({ '--dump-sourcemap', '--dump-assetmap', `--platform=${platformFlag}`, - ...(dev ? ['--dev'] : []), ...(clearCache ? ['--clear'] : []), ]); } @@ -230,7 +227,6 @@ export async function buildBundlesAsync({ '--dump-sourcemap', '--dump-assetmap', ...platformArgs, - ...(dev ? ['--dev'] : []), ...(clearCache ? ['--clear'] : []), ]); } @@ -252,7 +248,6 @@ export async function buildBundlesAsync({ '--dump-sourcemap', '--dump-assetmap', `--platform=${platformFlag}`, - ...(dev ? ['--dev'] : []), ...(clearCache ? ['--clear'] : []), ]); }